feat(cloud_sql): Add samples for Advanced DR switchover for MySQL and PostgreSQL #814

seviet · 2025-02-23T23:58:39Z

Description

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

Yes, merge this PR after it is approved
No, don't merge this PR after it is approved

Style

My sample follows the rules described for Terraform in the Effective Samples style guide
My sample follows the other requirements and best practices in the Contributing
guide

Testing

I have performed tests described in the Contributing guide:
- Tests pass: terraform apply
- Lint pass: terraform fmt check

Intended location

Yes, this sample will be (or already is) included on cloud.google.com
Location(s):
No, this sample won't be included on cloud.google.com
Reason:

API enablement

If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

Fix tag name

update tag name

snippet-bot · 2025-02-23T23:58:46Z

Here is the summary of changes.

You are about to add 8 region tags.

cloud_sql/mysql_instance_switchover/dr_replica_create/main.tf:18, tag cloud_sql_mysql_instance_switchover_dr_replica_create
cloud_sql/mysql_instance_switchover/dr_replica_designate/main.tf:17, tag cloud_sql_mysql_instance_switchover_dr_replica_designate
cloud_sql/mysql_instance_switchover/switchover_begin/main.tf:17, tag cloud_sql_mysql_instance_switchover_begin
cloud_sql/mysql_instance_switchover/switchover_finish/main.tf:17, tag cloud_sql_mysql_instance_switchover_finish
cloud_sql/postgres_instance_switchover/dr_replica_create/main.tf:18, tag cloud_sql_postgres_instance_switchover_dr_replica_create
cloud_sql/postgres_instance_switchover/dr_replica_designate/main.tf:17, tag cloud_sql_postgres_instance_switchover_dr_replica_designate
cloud_sql/postgres_instance_switchover/switchover_begin/main.tf:17, tag cloud_sql_postgres_instance_switchover_begin
cloud_sql/postgres_instance_switchover/switchover_finish/main.tf:17, tag cloud_sql_postgres_instance_switchover_finish

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

glasnt · 2025-02-26T05:12:23Z

/gcbrun

glasnt · 2025-02-26T05:39:55Z

Linting is failing with whitespace issues:

./cloud_sql/mysql_instance_switchover/switchover_finish/main.tf:25:# Terraform has compared your real infrastructure against your configuration and found no differences, 
./cloud_sql/mysql_instance_switchover/switchover_finish/main.tf:40:  # replica_names = [] # If you previously defined a replica_names field in your template, then delete the DR replica 
./cloud_sql/mysql_instance_switchover/switchover_finish/main.tf:41:  # (new primary) from the list of replicas.  Don't delete the entire replica_names field. 
./cloud_sql/mysql_instance_switchover/switchover_finish/main.tf:42:  # Instead set the field to an empty string. For example, replica_names = [""]. 
./cloud_sql/postgres_instance_switchover/switchover_finish/main.tf:24:# Terraform has compared your real infrastructure against your configuration and found no differences, 
./cloud_sql/postgres_instance_switchover/switchover_finish/main.tf:39:  # replica_names = [] # If you previously defined a replica_names field in your template, then delete the DR replica 
./cloud_sql/postgres_instance_switchover/switchover_finish/main.tf:40:  # (new primary) from the list of replicas.  Don't delete the entire replica_names field. 
./cloud_sql/postgres_instance_switchover/switchover_finish/main.tf:41:  # Instead set the field to an empty string. For example, replica_names = [""]. 
Error: Trailing whitespace found in the lines above.

cloud_sql/mysql_instance_switchover/dr_replica_create/main.tf

glasnt · 2025-02-26T05:42:53Z

/gcbrun

glasnt · 2025-02-26T22:08:49Z

/gcbrun

cloud_sql/mysql_instance_switchover/dr_replica_create/main.tf

cloud_sql/mysql_instance_switchover/dr_replica_designate/main.tf

cloud_sql/postgres_instance_switchover/dr_replica_create/main.tf

glasnt · 2025-02-26T22:20:51Z

/gcbrun

cloud_sql/postgres_instance_switchover/switchover_begin/main.tf

glasnt · 2025-02-26T22:56:45Z

/gcbrun

… PostgreSQL (terraform-google-modules#814) * feat: Add MySQL & PostgreSQL samples for Advanced DR switchover * Fix region tag * Update test.yaml Fix tag name * Update test.yaml update tag name * Update test.yaml update tag name * lint: whitespace * lint: whitespace * Remove unnecessary comments * Remove unnecessary comments * Remove unnecessary comments * linting * lint --------- Co-authored-by: Katie McLaughlin <[email protected]>

seviet and others added 6 commits February 22, 2025 02:43

feat: Add MySQL & PostgreSQL samples for Advanced DR switchover

694eb60

Merge branch 'terraform-google-modules:main' into b-389990775

25db941

Fix region tag

9393f9c

Update test.yaml

f1be149

Fix tag name

Update test.yaml

56c5a0d

update tag name

Update test.yaml

69a7d11

update tag name

seviet requested a review from a team as a code owner February 23, 2025 23:58

glasnt added 2 commits February 26, 2025 16:40

lint: whitespace

1f6fb3c

lint: whitespace

4713e77